Skip to content

Update SW and OS versions in CI #3344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Update SW and OS versions in CI #3344

wants to merge 4 commits into from

Conversation

@Alexsandruss
Copy link
Contributor

Description

Checklist:

Completeness and readability

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with updates and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least a summary table with measured data, if performance change is expected.
  • I have provided justification why performance and/or quality metrics have changed or why changes are not expected.
  • I have extended the benchmarking suite and provided a corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

@Alexsandruss Alexsandruss added the dependencies Pull requests that update a dependency file label Sep 2, 2025
@david-cortes-intel
Copy link
Contributor

The CI error:

You might want to run 'apt --fix-broken install' to correct these.
The following packages have unmet dependencies:
 cmake : Depends: libjsoncpp25 (>= 1.9.5) but it is not going to be installed
         Depends: librhash0 (>= 1.2.6) but it is not going to be installed
         Depends: cmake-data (= 3.28.3-1build7) but it is not going to be installed
 qemu-user-binfmt : Breaks: qemu-user-static
E: Unmet dependencies. Try 'apt --fix-broken install' with no packages (or specify a solution).

Is it perhaps trying to call apt-get with non-default arguments somewhere?

@david-cortes-intel
Copy link
Contributor

david-cortes-intel commented Sep 2, 2025 •
edited
Loading

Looks like it expects the GNU standard C++ library to build TBB, even if the compiler is clang.

@david-cortes-intel david-cortes-intel mentioned this pull request Sep 3, 2025
Closed
1 task
icfaust
icfaust reviewed Sep 9, 2025
View reviewed changes
Copy link
Contributor

@icfaust icfaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions to make these solutions longer term.

.ci/pipeline/ci.yml
SYSROOT_CACHE_DIR: $(Pipeline.Workspace)/sysroot-riscv64
pool:
vmImage: 'ubuntu-22.04'
vmImage: 'ubuntu-24.04'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
vmImage: 'ubuntu-24.04'
vmImage: '$(VM_IMAGE)'

.ci/pipeline/ci.yml
strategy:
matrix:
Python311:
Python313:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Python313:
Python3:

.ci/pipeline/ci.yml
strategy:
matrix:
Python311:
Python313:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Python313:
Python3:

.ci/env/tbb.sh
cmake_options=(-DCMAKE_TOOLCHAIN_FILE="${toolchain_file}"
-DCMAKE_BUILD_TYPE=Release
-DTBB_TEST=OFF
-DTBB_STRICT_PROTOTYPES=OFF
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some information on this change would be nice.

.ci/env/apt.sh
found_version=$(wget -q http://ftp.debian.org/debian/pool/main/q/qemu/ -O - | grep -oP "(?<=\")$1_.*_amd64.deb(?=\")" | tail -1)
wget http://ftp.debian.org/debian/pool/main/q/qemu/${found_version}
sudo dpkg -i ${found_version}
# in case of broken dependencies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This qemu installation continues to be a high-maintenace aspect. Is this something that renovatebot can manage for us given it comes from an apt install?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icfaust icfaust icfaust left review comments

@napetrov napetrov Awaiting requested review from napetrov napetrov will be requested when the pull request is marked ready for review napetrov is a code owner

@homksei homksei Awaiting requested review from homksei homksei will be requested when the pull request is marked ready for review homksei is a code owner

@ahuber21 ahuber21 Awaiting requested review from ahuber21 ahuber21 will be requested when the pull request is marked ready for review ahuber21 is a code owner

@ethanglaser ethanglaser Awaiting requested review from ethanglaser ethanglaser will be requested when the pull request is marked ready for review ethanglaser is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Alexsandruss @david-cortes-intel @icfaust