cpu: x64: matmul: check src md instead of src tag #4209
+64
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform:cpu-x64
densamoilov
force-pushed
the
dsamoylo/main/fix-md-check
branch
2 times, most recently
from
940aa48 to
5f915a5
Compare
Multiple tags can correspond to the same physical layout when unit dimensions are present; therefore, we cannot rely on tags in cases where it matters. The newly introduced `is_canonical()` function can be used to perform certain checks in a robust way.
densamoilov
force-pushed
the
dsamoylo/main/fix-md-check
branch
from
5f915a5 to
873ef15
Compare
inteldimitrius
approved these changes
Oct 25, 2025
ankalinin
approved these changes
Oct 25, 2025
densamoilov
commented
Oct 25, 2025
|
|
||
| if (normalized_ndims == 0) return true; | ||
|
|
||
| int expected_stride = 1; |
There was a problem hiding this comment.
(reminder for myself) use dim_t instead of int
avmanerikar
approved these changes
Oct 27, 2025
| } | ||
| } | ||
|
|
||
| if (normalized_ndims == 0) return true; |
There was a problem hiding this comment.
(nit):
Suggested change
| if (normalized_ndims == 0) return true; | |
| if (!normalized_ndims) return true; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple tags can correspond to the same physical layout when unit dimensions are present; therefore, we cannot rely on tags in cases where it matters. The newly introduced
is_canonical()function can be used to perform certain checks in a robust way.Fixes MFDNN-14321.