-
Couldn't load subscription status.
- Fork 184
Add rbf_kernel Function #2348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add rbf_kernel Function #2348
Conversation
* chore(deps): update dependency jinja2 to v3.1.6 [security] (uxlfoundation#2345) * feature: add RBF kernel implementation and integrate with dispatcher * integrate RBF kernel in sklearnex/metrics * add benchmark_rbf_kernel.ipynb * revert Jinja2 version change * remove unused RBF kernel mapping from dispatcher --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Andrie Dazlee, Nurin Miza Afiqah <nurin.miza.afiqah.andrie.dazlee@intel.com> Signed-off-by: Andrie Dazlee, Nurin Miza Afiqah <nurin.miza.afiqah.andrie.dazlee@intel.com> Signed-off-by: Mohamad, Siti Nurhanisah <siti.nurhanisah.mohamad@intel.com> Signed-off-by: Tan, An Nie <an.nie.tan@intel.com>
Codecov ReportAttention: Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 43 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
@tanannie22 would you like to continue working on it? |
Hi @syakov-intel, I'm still working on this, but I'm currently facing some challenges with enabling the function to compute on GPU. If you have any ideas on enabling the function to compute on GPU, it would really help me move faster. I’d appreciate any suggestions! |
Description
Issue: #2313
Changes Made:
sklearnex/metrics/pairwise.pyto utilizeoneDALforrbf_kernel.sklearnex/metrics/tests/test_metrics.pyto validate correctness.examples/notebooks/benchmark_rbf_kernel.ipynb) to compare performance betweensklearnandsklearnex.PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance