-
Notifications
You must be signed in to change notification settings - Fork 4
chore: simplify generator #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some TeamCity agents still run Node 18, which means that building the project would not work there. See also #311.
Let's see that agents are updated first before merging this.
|
|
This PR significantly simplifies React wrapper generation; instead of TypeScript AST, it uses plain strings which improves the readability of the code. The code has been reduced by more than half as well. TypeScript is still used for catching syntax errors and apply common style in generated files; though, we can remove this step if needed.
Also, the generator script drops the customfswalkandfromAsyncfunctions in favor of the nativeglob(it is experimental but since it is our internal script I consider it ok). However, this change requires Node v22 LTS.Since there are two packages managed by a root
tsconfig, andglobneeds newer TS libs, I had to switch the root toesnext. To keep packages ones2021, I created separatetsconfig.jsonfiles for each package. So, now, we can usees2021for packages and use any modern stuff in our scripts.EDIT:
Since I faced an issue in vaadin/hilla repo (we use Node v20 instead of Node v22 for building Vaadin 24.x, and going to move to Node v22 only in Vaadin 25), I decided to replace the native
globwith the similar implementation from thenode-globpackage. I have also replaced all the obsolete utils (fswalkandfromAsync) with theglob, which revealed a minor error in thepackage.jsonupdate (deeply nested CSS folders were not visited and put into thepackage.json).