- 
                Notifications
    You must be signed in to change notification settings 
- Fork 11
ci(tests) Verify runtime deps #486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| Reviewer's Guide by SourceryThis pull request introduces a new CI job to verify the project's runtime dependencies. It uses  No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
 Tips and commandsInteracting with Sourcery
 Customizing Your ExperienceAccess your dashboard to: 
 Getting Help
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tony - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using python -m libvcsinstead of importing all modules to verify the installation.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
936a2d0    to
    04faf16      
    Compare
  
    04faf16    to
    23981e9      
    Compare
  
    
Changes
uv run --no-devCHANGESSummary by Sourcery
Add a CI job to verify runtime dependencies before installing dev dependencies. This ensures that the package functions correctly with only its runtime dependencies installed.
CI:
uv run --no-devbefore installing dev dependencies.