Feature/python3 #111
Open
Feature/python3 #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bytes not str, metaclasses, slots suck etc
If you can specify how many tracks, instead of using len(pattern), you could stream tracks to the destination (timidity or whatever). There's little point in doing this for tracks, since their length has to be the BYTE count of all their events. If you can count how many bytes a collection of MIDI events is going to be, without accumulating them into a byte buffer, you're a better soul than I.
Semantics of division changed in python 3 (PEP 238 https://www.python.org/dev/peps/pep-0238/) in python 2, divion of int by int returned int via floor division, now returns float
bytes not str, metaclasses, slots suck etc
If you can specify how many tracks, instead of using len(pattern), you could stream tracks to the destination (timidity or whatever). There's little point in doing this for tracks, since their length has to be the BYTE count of all their events. If you can count how many bytes a collection of MIDI events is going to be, without accumulating them into a byte buffer, you're a better soul than I.
Wasn't writing the byte if the record status hadn't changed, which broke things.
|
Is it possible to push Python3 into PIP so we don't have to clone this repository every time we want to install? |
Open
LESSSE
approved these changes
Aug 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.