-
Notifications
You must be signed in to change notification settings - Fork 37
Blog for vllm optimizations on Intel GPU #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Update the vllm optimizations and support on Intel GPU, using ARC Pro B series product. Signed-off-by: roger feng <roger.feng@intel.com>
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@hmellor Thanks for the review! Comments are addressed. |
address the review comments Signed-off-by: roger feng <roger.feng@intel.com>
|
Looks nice, just 2 unresolved comments about the side by side images and the formatting of a line which might look nicer in code format. |
Minor format changes on the side-by-side figures and using code format for formula Signed-off-by: roger feng <roger.feng@intel.com>
The two comments are addressed. Looks better. Thanks! |
hmellor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Now you can just update the file name to today's date and we can publish!
The vllm optimizations and support on Intel GPU, using ARC Pro B series cards to showcase the performance.