Fix for Duplicate Uppercase/Lowercase Hashes #99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issue #98.
In
magnetURIDecode, thextparameter is stored as-is in the result object:The function then extracts the info hash and converts it to lowercase:
So the decoded object has both:
Then, in
magnetURIEncode:Since the Set treats these as different strings (case-sensitive), both get added, resulting in duplicate
xtparameters.The issue should be fixed in the decode function by normalizing the
xtparameter when it contains a BitTorrent info hash.This fix ensures that:
xtparameters in the encoded outputxtURN types are left unchanged