- 
                Notifications
    You must be signed in to change notification settings 
- Fork 64
Add experimental support to build using Bikeshed #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
        
          
                src/main.rs
              
                Outdated
          
        
      | // Find the paths we need. | ||
| let cache_dir = path_from_env("HTML_CACHE", ".cache"); | ||
| let source_dir = path_from_env("HTML_SOURCE", "../html"); | ||
| let use_bikeshed_str = env::var_os("USE_BIKESHED"); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd probably be less messy to use a --bikeshed command line arg.
This ends up quite noisy in the output and can probably be minified somehow. It does link more things together however.
| Although this is far from complete, I'd like to add the experimental mode to html-build to make collaboration on it easier. At TPAC I'd like to demo how to use it (which is a lot easier if this is merged) and where people can help out if they're interested. I'm happy to clean up some things if requested, I wrote this as an experiment and probably left a few weird things in that need explaining or removing. | 
| Happy to rubber stamp this, but let's give @sideshowbarker and @zcorpan a chance to chime in as well. | 
| 
 Same here. This is epic and it seems like it could go ahead and be landed — for the reasons Philip outlined in https://github.com/whatwg/html-build/pull/296#issuecomment-3464324423 — and any further work could be handled in follow-up PRs | 
No description provided.