Skip to content

TabController - fix touch events not triggered on real Android device when scrolling with zIndex change #3829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 5, 2025
Merged

TabController - fix touch events not triggered on real Android device when scrolling with zIndex change #3829

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
929b334
TabController - fix touch events not triggered on real Android device…
M-i-k-e-l Nov 2, 2025
8ea00d7
Do not return null, use opacity\zIndex in a regular style
M-i-k-e-l Nov 4, 2025
d9c46d3
Improve the comment
M-i-k-e-l Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 18 additions & 16 deletions src/components/tabController/TabPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ export default function TabPage({
}: PropsWithChildren<TabControllerPageProps>) {
const {currentPage, asCarousel, nestedInScrollView, containerWidth} = useContext(TabBarContext);
const [shouldLoad, setLoaded] = useState(!lazy);

// TODO: RN 77 hack - remove the state in future RN\reanimated release (ticket 4838 \ https://github.com/software-mansion/react-native-reanimated/issues/8517) when fixed we should revert to the original logic (see this PR: https://github.com/wix/react-native-ui-lib/pull/3829)
const [isActive, setIsActive] = useState(currentPage.value === index);
// const [focused, setFocused] = useState(false);

const lazyLoad = useCallback(() => {
Expand All @@ -61,6 +64,7 @@ export default function TabPage({
},
(currentPage /* , previousPage */) => {
const isActive = currentPage === index;
runOnJS(setIsActive)(isActive);
// const wasActive = previousPage === index;
// const nearActive = asCarousel && (currentPage - 1 === index || currentPage + 1 === index);
// const wasNearActive =
Expand All @@ -79,24 +83,24 @@ export default function TabPage({
[currentPage, lazyLoad]);

const animatedPageStyle = useAnimatedStyle(() => {
const isActive = Math.round(currentPage.value) === index;

// TODO: Fix to proper animated style once Reanimated export AnimatedStyleProp
const style: any = {
opacity: isActive || asCarousel ? 1 : 0,
zIndex: isActive || asCarousel ? 1 : 0
};

if (nestedInScrollView) {
style.position = isActive ? 'relative' : 'absolute';
if (!nestedInScrollView) {
return {};
}

return style;
const isActive = Math.round(currentPage.value) === index;

return {position: isActive ? 'relative' : 'absolute'};
});

const _style = useMemo(() => {
return [!asCarousel && styles.page, animatedPageStyle, {width: asCarousel ? containerWidth : undefined}, style];
}, [asCarousel, animatedPageStyle, containerWidth, style]);
return [
!asCarousel && styles.page,
animatedPageStyle,
{width: asCarousel ? containerWidth : undefined},
style,
!isActive && !asCarousel ? {opacity: 0, zIndex: 0} : {opacity: 1, zIndex: 1}
];
}, [asCarousel, animatedPageStyle, containerWidth, style, isActive]);

return (
<Reanimated.View style={_style} testID={testID}>
Expand All @@ -108,7 +112,5 @@ export default function TabPage({
}

const styles = StyleSheet.create({
page: {
...StyleSheet.absoluteFillObject
}
page: StyleSheet.absoluteFillObject
});