nv2a: Fix handling of color/zeta offset with RAM addresses #2158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abaire
force-pushed
the
fix_326_color_offset_using_ram_addr
branch
from
12c8dac to
fdb9ae6
Compare
abaire
force-pushed
the
fix_326_color_offset_using_ram_addr
branch
2 times, most recently
from
90aeccd to
42c0aa3
Compare
abaire
force-pushed
the
fix_326_color_offset_using_ram_addr
branch
from
42c0aa3 to
cb0b70b
Compare
|
Hopefully, @mborgerson can take a look at this? Thanks. |
abaire
force-pushed
the
fix_326_color_offset_using_ram_addr
branch
from
cb0b70b to
3c6dd75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #326
ESPN NFL Football sets the color surface offset using a RAM address (
0x83ba0000) rather than the equivalent VRAM range (0x03ba0000). The game modifies the 0x880 register to disable the associated limit exception similar to what was seen previously in Spongebob.While we could implement the limit exceptions and handle the 0x880 flag to emulate hardware, it is simpler to allow RAM addresses by masking off the high nibble.