setup.py: drop data_files, installs LICENSE to incorrect place #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in issue xmlrunner#284, the data_files statement in the setup() calls installs the LICENSE file in the wrong place: in /usr/LICENSE, or even /LICENSE depending on the configuration. So let's drop this, and let setuptools install the LICENSE file automatically: since setuptools v56, the license_files attribute is automatically assigned to a default value, which includes "LICENSE", so there is in fact nothing to do to the get the LICENSE file installed at the correct location. See https://setuptools.pypa.io/en/latest/history.html#v56-0-0. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in issue
#284, the data_files statement in the setup() calls installs the LICENSE file in the wrong place: in /usr/LICENSE, or even /LICENSE depending on the configuration.
So let's drop this, and let setuptools install the LICENSE file automatically: since setuptools v56, the license_files attribute is automatically assigned to a default value, which includes "LICENSE", so there is in fact nothing to do to the get the LICENSE file installed at the correct location. See
https://setuptools.pypa.io/en/latest/history.html#v56-0-0.