Update render function params to floating point #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain render methods in SDL3 support subpixel resolution and expect FRects and FPoints instead of integer Rects and Points in SDL2. https://wiki.libsdl.org/SDL3/SDL_RenderTexture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that specifying a src and/or dst
Rectto renderTexture made it stop rendering at all for me, and noticed certain render functions in SDL3 now support subpixel resolution and expectFRects andFPoints instead of integerRects andPoints in SDL2. I did a quick pass and I think the rest of the render related functions are correct (with some missing which I'll add in another PR)