Skip to content

Conversation

@Zirunis
Copy link

@Zirunis Zirunis commented Oct 22, 2025

I just stumbled across this while reading the docs. Basically the build instructions and output of the example are missing.
Took me a while to figure out how to fix it, but I think this should be it?
I didn't render it myself because I don't know how yet so please double-check before merging!

@Zirunis Zirunis changed the title Fixed missing example output for float_mode_exe.zig Docs: Fixed missing example output for float_mode_exe.zig Oct 22, 2025
@IOKG04
Copy link
Contributor

IOKG04 commented Oct 23, 2025

I'd guess that all the programs get compiled (and run) individually, so it cannot use the symbols defined in float_mode_obj.zig. Thus the linking errors in all the already failed CI checks.

@Zirunis
Copy link
Author

Zirunis commented Oct 23, 2025

I'd guess that all the programs get compiled (and run) individually, so it cannot use the symbols defined in float_mode_obj.zig. Thus the linking errors in all the already failed CI checks.

Yeah, I think so too. I'm gonna see if I can figure it out tomorrow. Maybe in this case just writing the expected output manually is the best approach. Doesn't make sense to overcomplicate things for one text field in the documentation that hasn't changed in 8 years.

@Zirunis Zirunis marked this pull request as draft October 23, 2025 21:53
@Zirunis Zirunis marked this pull request as ready for review October 23, 2025 22:18
@Zirunis
Copy link
Author

Zirunis commented Oct 24, 2025

I manually added the shell output to langref.html.in now and added a comment to the code example why it can't currently be automated. I suspect Andrew ran across this exact issue when he migrated the langref to the build system, switched the example to syntax highlighting only, and then forgot to manually add the output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants