Skip to content

page: Split empty-page placeholder messages into header and message #1946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2025
Merged

page: Split empty-page placeholder messages into header and message #1946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions assets/l10n/app_en.arb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,8 @@
"@allChannelsPageTitle": {
"description": "Title for the 'All channels' page."
},
"allChannelsEmptyPlaceholder": "There are no channels you can view in this organization.",
"@allChannelsEmptyPlaceholder": {
"allChannelsEmptyPlaceholderHeader": "There are no channels you can view in this organization.",
"@allChannelsEmptyPlaceholderHeader": {
"description": "Centered text on the 'All channels' page saying that there is no content to show."
},
"profileButtonSendDirectMessage": "Send direct message",
Expand Down Expand Up @@ -1090,10 +1090,14 @@
"@inboxPageTitle": {
"description": "Title for the page with unreads."
},
"inboxEmptyPlaceholder": "There are no unread messages in your inbox. Use the buttons below to view the combined feed or list of channels.",
"@inboxEmptyPlaceholder": {
"inboxEmptyPlaceholderHeader": "There are no unread messages in your inbox.",
"@inboxEmptyPlaceholderHeader": {
"description": "Centered text on the 'Inbox' page saying that there is no content to show."
},
"inboxEmptyPlaceholderMessage": "Use the buttons below to view the combined feed or list of channels.",
"@inboxEmptyPlaceholderMessage": {
"description": "Additional centered text on the 'Inbox' page saying that there is no content to show."
},
"recentDmConversationsPageTitle": "Direct messages",
"@recentDmConversationsPageTitle": {
"description": "Title for the page with a list of DM conversations."
Expand All @@ -1102,10 +1106,14 @@
"@recentDmConversationsSectionHeader": {
"description": "Heading for direct messages section on the 'Inbox' message view."
},
"recentDmConversationsEmptyPlaceholder": "You have no direct messages yet! Why not start the conversation?",
"@recentDmConversationsEmptyPlaceholder": {
"recentDmConversationsEmptyPlaceholderHeader": "You have no direct messages yet!",
"@recentDmConversationsEmptyPlaceholderHeader": {
"description": "Centered text on the 'Direct messages' page saying that there is no content to show."
},
"recentDmConversationsEmptyPlaceholderMessage": "Why not start a conversation?",
"@recentDmConversationsEmptyPlaceholderMessage": {
"description": "Additional centered text on the 'Direct messages' page saying that there is no content to show."
},
"combinedFeedPageTitle": "Combined feed",
"@combinedFeedPageTitle": {
"description": "Page title for the 'Combined feed' message view."
Expand All @@ -1122,12 +1130,12 @@
"@channelsPageTitle": {
"description": "Title for the page with a list of subscribed channels."
},
"channelsEmptyPlaceholder": "You’re not subscribed to any channels yet.",
"@channelsEmptyPlaceholder": {
"channelsEmptyPlaceholderHeader": "You’re not subscribed to any channels yet.",
"@channelsEmptyPlaceholderHeader": {
"description": "Centered text on the 'Channels' page saying that there is no content to show."
},
"channelsEmptyPlaceholderWithAllChannelsLink": "You’re not subscribed to any channels yet. Try going to <z-link>{allChannelsPageTitle}</z-link> and joining some of them.",
"@channelsEmptyPlaceholderWithAllChannelsLink": {
"channelsEmptyPlaceholderMessage": "Try going to <z-link>{allChannelsPageTitle}</z-link> and joining some of them.",
"@channelsEmptyPlaceholderMessage": {
"description": "Centered text on the 'Channels' page saying that there is no content to show, with a link to 'All channels'.",
"placeholders": {
"allChannelsPageTitle": {"type": "String", "example": "All channels"}
Expand Down
30 changes: 20 additions & 10 deletions lib/generated/l10n/zulip_localizations.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ abstract class ZulipLocalizations {
///
/// In en, this message translates to:
/// **'There are no channels you can view in this organization.'**
String get allChannelsEmptyPlaceholder;
String get allChannelsEmptyPlaceholderHeader;

/// Label for button in profile screen to navigate to DMs with the shown user.
///
Expand Down Expand Up @@ -1620,8 +1620,14 @@ abstract class ZulipLocalizations {
/// Centered text on the 'Inbox' page saying that there is no content to show.
///
/// In en, this message translates to:
/// **'There are no unread messages in your inbox. Use the buttons below to view the combined feed or list of channels.'**
String get inboxEmptyPlaceholder;
/// **'There are no unread messages in your inbox.'**
String get inboxEmptyPlaceholderHeader;

/// Additional centered text on the 'Inbox' page saying that there is no content to show.
///
/// In en, this message translates to:
/// **'Use the buttons below to view the combined feed or list of channels.'**
String get inboxEmptyPlaceholderMessage;

/// Title for the page with a list of DM conversations.
///
Expand All @@ -1638,8 +1644,14 @@ abstract class ZulipLocalizations {
/// Centered text on the 'Direct messages' page saying that there is no content to show.
///
/// In en, this message translates to:
/// **'You have no direct messages yet! Why not start the conversation?'**
String get recentDmConversationsEmptyPlaceholder;
/// **'You have no direct messages yet!'**
String get recentDmConversationsEmptyPlaceholderHeader;

/// Additional centered text on the 'Direct messages' page saying that there is no content to show.
///
/// In en, this message translates to:
/// **'Why not start a conversation?'**
String get recentDmConversationsEmptyPlaceholderMessage;

/// Page title for the 'Combined feed' message view.
///
Expand Down Expand Up @@ -1669,15 +1681,13 @@ abstract class ZulipLocalizations {
///
/// In en, this message translates to:
/// **'You’re not subscribed to any channels yet.'**
String get channelsEmptyPlaceholder;
String get channelsEmptyPlaceholderHeader;

/// Centered text on the 'Channels' page saying that there is no content to show, with a link to 'All channels'.
///
/// In en, this message translates to:
/// **'You’re not subscribed to any channels yet. Try going to <z-link>{allChannelsPageTitle}</z-link> and joining some of them.'**
String channelsEmptyPlaceholderWithAllChannelsLink(
String allChannelsPageTitle,
);
/// **'Try going to <z-link>{allChannelsPageTitle}</z-link> and joining some of them.'**
String channelsEmptyPlaceholderMessage(String allChannelsPageTitle);

/// Title for the page about sharing content received from other apps.
///
Expand Down
26 changes: 16 additions & 10 deletions lib/generated/l10n/zulip_localizations_ar.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
String get allChannelsPageTitle => 'All channels';

@override
String get allChannelsEmptyPlaceholder =>
String get allChannelsEmptyPlaceholderHeader =>
'There are no channels you can view in this organization.';

@override
Expand Down Expand Up @@ -911,8 +911,12 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
String get inboxPageTitle => 'Inbox';

@override
String get inboxEmptyPlaceholder =>
'There are no unread messages in your inbox. Use the buttons below to view the combined feed or list of channels.';
String get inboxEmptyPlaceholderHeader =>
'There are no unread messages in your inbox.';

@override
String get inboxEmptyPlaceholderMessage =>
'Use the buttons below to view the combined feed or list of channels.';

@override
String get recentDmConversationsPageTitle => 'Direct messages';
Expand All @@ -921,8 +925,12 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
String get recentDmConversationsSectionHeader => 'Direct messages';

@override
String get recentDmConversationsEmptyPlaceholder =>
'You have no direct messages yet! Why not start the conversation?';
String get recentDmConversationsEmptyPlaceholderHeader =>
'You have no direct messages yet!';

@override
String get recentDmConversationsEmptyPlaceholderMessage =>
'Why not start a conversation?';

@override
String get combinedFeedPageTitle => 'Combined feed';
Expand All @@ -937,14 +945,12 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
String get channelsPageTitle => 'Channels';

@override
String get channelsEmptyPlaceholder =>
String get channelsEmptyPlaceholderHeader =>
'You’re not subscribed to any channels yet.';

@override
String channelsEmptyPlaceholderWithAllChannelsLink(
String allChannelsPageTitle,
) {
return 'You’re not subscribed to any channels yet. Try going to <z-link>$allChannelsPageTitle</z-link> and joining some of them.';
String channelsEmptyPlaceholderMessage(String allChannelsPageTitle) {
return 'Try going to <z-link>$allChannelsPageTitle</z-link> and joining some of them.';
}

@override
Expand Down
29 changes: 18 additions & 11 deletions lib/generated/l10n/zulip_localizations_de.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@ class ZulipLocalizationsDe extends ZulipLocalizations {
String get allChannelsPageTitle => 'Alle Kanäle';

@override
String get allChannelsEmptyPlaceholder =>
'Es gibt in dieser Organisation keine Kanäle die du ansehen kannst.';
String get allChannelsEmptyPlaceholderHeader =>
'There are no channels you can view in this organization.';

@override
String get profileButtonSendDirectMessage => 'Direktnachricht senden';
Expand Down Expand Up @@ -936,8 +936,12 @@ class ZulipLocalizationsDe extends ZulipLocalizations {
String get inboxPageTitle => 'Eingang';

@override
String get inboxEmptyPlaceholder =>
'Es sind keine ungelesenen Nachrichten in deinem Eingang. Verwende die Buttons unten, um den kombinierten Feed oder die Kanalliste anzusehen.';
String get inboxEmptyPlaceholderHeader =>
'There are no unread messages in your inbox.';

@override
String get inboxEmptyPlaceholderMessage =>
'Use the buttons below to view the combined feed or list of channels.';

@override
String get recentDmConversationsPageTitle => 'Direktnachrichten';
Expand All @@ -946,8 +950,12 @@ class ZulipLocalizationsDe extends ZulipLocalizations {
String get recentDmConversationsSectionHeader => 'Direktnachrichten';

@override
String get recentDmConversationsEmptyPlaceholder =>
'Du hast noch keine Direktnachrichten! Warum nicht die Unterhaltung beginnen?';
String get recentDmConversationsEmptyPlaceholderHeader =>
'You have no direct messages yet!';

@override
String get recentDmConversationsEmptyPlaceholderMessage =>
'Why not start a conversation?';

@override
String get combinedFeedPageTitle => 'Kombinierter Feed';
Expand All @@ -962,13 +970,12 @@ class ZulipLocalizationsDe extends ZulipLocalizations {
String get channelsPageTitle => 'Kanäle';

@override
String get channelsEmptyPlaceholder => 'Du hast noch keine Kanäle abonniert.';
String get channelsEmptyPlaceholderHeader =>
'You’re not subscribed to any channels yet.';

@override
String channelsEmptyPlaceholderWithAllChannelsLink(
String allChannelsPageTitle,
) {
return 'Du hast noch keine Kanäle abonniert. Probiere zu <z-link>$allChannelsPageTitle</z-link> zu gehen und ein paar von ihnen beizutreten.';
String channelsEmptyPlaceholderMessage(String allChannelsPageTitle) {
return 'Try going to <z-link>$allChannelsPageTitle</z-link> and joining some of them.';
}

@override
Expand Down
26 changes: 16 additions & 10 deletions lib/generated/l10n/zulip_localizations_el.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ class ZulipLocalizationsEl extends ZulipLocalizations {
String get allChannelsPageTitle => 'All channels';

@override
String get allChannelsEmptyPlaceholder =>
String get allChannelsEmptyPlaceholderHeader =>
'There are no channels you can view in this organization.';

@override
Expand Down Expand Up @@ -911,8 +911,12 @@ class ZulipLocalizationsEl extends ZulipLocalizations {
String get inboxPageTitle => 'Inbox';

@override
String get inboxEmptyPlaceholder =>
'There are no unread messages in your inbox. Use the buttons below to view the combined feed or list of channels.';
String get inboxEmptyPlaceholderHeader =>
'There are no unread messages in your inbox.';

@override
String get inboxEmptyPlaceholderMessage =>
'Use the buttons below to view the combined feed or list of channels.';

@override
String get recentDmConversationsPageTitle => 'Direct messages';
Expand All @@ -921,8 +925,12 @@ class ZulipLocalizationsEl extends ZulipLocalizations {
String get recentDmConversationsSectionHeader => 'Direct messages';

@override
String get recentDmConversationsEmptyPlaceholder =>
'You have no direct messages yet! Why not start the conversation?';
String get recentDmConversationsEmptyPlaceholderHeader =>
'You have no direct messages yet!';

@override
String get recentDmConversationsEmptyPlaceholderMessage =>
'Why not start a conversation?';

@override
String get combinedFeedPageTitle => 'Combined feed';
Expand All @@ -937,14 +945,12 @@ class ZulipLocalizationsEl extends ZulipLocalizations {
String get channelsPageTitle => 'Channels';

@override
String get channelsEmptyPlaceholder =>
String get channelsEmptyPlaceholderHeader =>
'You’re not subscribed to any channels yet.';

@override
String channelsEmptyPlaceholderWithAllChannelsLink(
String allChannelsPageTitle,
) {
return 'You’re not subscribed to any channels yet. Try going to <z-link>$allChannelsPageTitle</z-link> and joining some of them.';
String channelsEmptyPlaceholderMessage(String allChannelsPageTitle) {
return 'Try going to <z-link>$allChannelsPageTitle</z-link> and joining some of them.';
}

@override
Expand Down
26 changes: 16 additions & 10 deletions lib/generated/l10n/zulip_localizations_en.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
String get allChannelsPageTitle => 'All channels';

@override
String get allChannelsEmptyPlaceholder =>
String get allChannelsEmptyPlaceholderHeader =>
'There are no channels you can view in this organization.';

@override
Expand Down Expand Up @@ -911,8 +911,12 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
String get inboxPageTitle => 'Inbox';

@override
String get inboxEmptyPlaceholder =>
'There are no unread messages in your inbox. Use the buttons below to view the combined feed or list of channels.';
String get inboxEmptyPlaceholderHeader =>
'There are no unread messages in your inbox.';

@override
String get inboxEmptyPlaceholderMessage =>
'Use the buttons below to view the combined feed or list of channels.';

@override
String get recentDmConversationsPageTitle => 'Direct messages';
Expand All @@ -921,8 +925,12 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
String get recentDmConversationsSectionHeader => 'Direct messages';

@override
String get recentDmConversationsEmptyPlaceholder =>
'You have no direct messages yet! Why not start the conversation?';
String get recentDmConversationsEmptyPlaceholderHeader =>
'You have no direct messages yet!';

@override
String get recentDmConversationsEmptyPlaceholderMessage =>
'Why not start a conversation?';

@override
String get combinedFeedPageTitle => 'Combined feed';
Expand All @@ -937,14 +945,12 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
String get channelsPageTitle => 'Channels';

@override
String get channelsEmptyPlaceholder =>
String get channelsEmptyPlaceholderHeader =>
'You’re not subscribed to any channels yet.';

@override
String channelsEmptyPlaceholderWithAllChannelsLink(
String allChannelsPageTitle,
) {
return 'You’re not subscribed to any channels yet. Try going to <z-link>$allChannelsPageTitle</z-link> and joining some of them.';
String channelsEmptyPlaceholderMessage(String allChannelsPageTitle) {
return 'Try going to <z-link>$allChannelsPageTitle</z-link> and joining some of them.';
}

@override
Expand Down
Loading