msglist: Friendlier placeholder text when narrow has no messages #1947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
force-pushed
the
pr-friendlier-msglist-placeholders
branch
from
263abf4 to
aaac065
Compare
No content access: link goes to the server's 
1:1 DM where the other user is deactivated: 1:1 DM with unknown user (reproduced artificially; I guess this could come up naturally for guest users?) 
Group DM where at least one user is deactivated: Link goes to the server's Link goes to the server's |
|
Oh, and common cases that are unchanged: Channel view: Topic view: Search results: |
chrisbobbe
force-pushed
the
pr-friendlier-msglist-placeholders
branch
from
aaac065 to
3a8eb20
Compare
|
Rebased, now that #1946 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked atop #1946.
Replaces #1640.
Fixes #1653.
cc @alya, screenshots below :)