feat: adds ssh implementation #34
Draft
+2,182
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency ReviewThe following issues were found:
License Issuespackage-lock.json
package.json
Allowed Licenses: MIT, MIT-0, Apache-2.0, BSD-3-Clause, BSD-3-Clause-Clear, ISC, BSD-2-Clause, Unlicense, CC0-1.0, 0BSD, X11, MPL-2.0, MPL-1.0, MPL-1.1, MPL-2.0, OFL-1.1, Zlib Excluded from license check: pkg:npm/caniuse-lite OpenSSF ScorecardScorecard details
Scanned Files
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dcoric
force-pushed
the
denis-coric/ssh
branch
2 times, most recently
from
105cf4b to
b6bf564
Compare
- Implement complete SSH server with public key and password authentication - Add SSH key management to user database (both File and MongoDB) - Create SSH CLI tools for key management - Add SSH configuration schema and TypeScript types - Integrate SSH server with main proxy lifecycle - Add REST endpoints for SSH key CRUD operations - Include comprehensive test suite and documentation - Support Git operations over SSH with full proxy chain integration
- Convert SSH server (src/proxy/ssh/server.js -> server.ts) - Convert SSH CLI tool (src/cli/ssh-key.js -> ssh-key.ts) - Add proper TypeScript types and interfaces - Install @types/ssh2 for SSH2 library types - Fix TypeScript compilation errors with type assertions - Update imports to use TypeScript files - Remove @ts-expect-error comment as no longer needed
dcoric
force-pushed
the
denis-coric/ssh
branch
from
8c3cae1 to
2bcb475
Compare
- Add email and gitAccount fields to SSHUser and AuthenticatedUser interfaces - Improve client connection handling by logging client IP and user details - Refactor handleClient method to accept client connection info - Enhance error handling and logging for better debugging - Update tests to reflect changes in client handling and authentication
dcoric
force-pushed
the
denis-coric/ssh
branch
from
489af1d to
0b38aee
Compare
- Update keepalive settings to recommended intervals for better connection stability - Implement cleanup of keepalive timers on client disconnects - Modify error handling to allow client recovery instead of closing connections - Improve logging for debugging client key usage and connection errors - Update tests to reflect changes in keepalive behavior and error handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces SSH support for Git operations and includes various updates to the configuration, authentication, and command-line interface. The most important changes are grouped by theme below.
SSH Support
SSH.md.config.schema.jsonto include SSH configuration options and thegitProtocolsetting. [1] [2]packages/git-proxy-cli/index.jsandsrc/cli/ssh-key.js. [1] [2] [3]Configuration Updates
proxy.config.jsonto include SSH settings and update thegitProtocolto support SSH. [1] [2]src/config/index.jsto handle SSH configuration and thegitProtocolsetting. [1] [2] [3]Database Enhancements
Dependency Updates
ssh2library topackage.jsonto support SSH operations.Logging and Debugging
loginfunction and added logging for SSH key actions inpackages/git-proxy-cli/index.js. [1] [2] [3]