Skip to content

Make fixer available via FileProxy #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Make fixer available via FileProxy #455

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Magento2/Internal/FileProxy.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ public function __construct(\PHP_CodeSniffer\Files\File $file, array $proxies =
{
$this->file = $file;
$this->proxies = $proxies;
$this->fixer = $file->fixer;
Copy link
Contributor

@bubasuma bubasuma May 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use magic methods _get()/_set() in order to fix the issue for all public properties.

Copy link
Member Author

@fredden fredden May 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is being removed in #452 (which I expect to be merged in this week), making further changes to this file seems like unnecessary work.

This change is the minimum required to make the tests pass. If you would like to add additional tests and write the necessary code to make them pass, please open a new pull request with those changes.

My recommendation would be to get this merged, then #453, then #452.

// parent constructor is not called intentionally
}

Expand Down