Make fixer available via FileProxy #455
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 29, 2023
ihor-sviziev
approved these changes
May 29, 2023
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
bubasuma
suggested changes
May 30, 2023
| { | ||
| $this->file = $file; | ||
| $this->proxies = $proxies; | ||
| $this->fixer = $file->fixer; |
Contributor
There was a problem hiding this comment.
Please use magic methods _get()/_set() in order to fix the issue for all public properties.
Member
Author
There was a problem hiding this comment.
This file is being removed in #452 (which I expect to be merged in this week), making further changes to this file seems like unnecessary work.
This change is the minimum required to make the tests pass. If you would like to add additional tests and write the necessary code to make them pass, please open a new pull request with those changes.
My recommendation would be to get this merged, then #453, then #452.
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: approved
labels
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If #452 gets merged before this pull request, this pull request can be safely closed as the problem files are being removed there.
This pull request has been created purely so that we can progress with #453, which is blocking #452. This is not intended to be a long-term fix.
This fixes #454