Add filters to upload table for organizations #1323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marlo-longley
force-pushed
the
activity-filters
branch
5 times, most recently
from
861117e to
4495731
Compare
marlo-longley
force-pushed
the
activity-filters
branch
from
4495731 to
7c7e6af
Compare
corylown
reviewed
Oct 27, 2025
| if params[:filter].present? | ||
| filter_status = params[:filter].to_sym | ||
|
|
||
| filtered_ids = @uploads.select do |upload| |
There was a problem hiding this comment.
I don't think this is going to scale to thousands (or 100k+ uploads). There's probably a faster but more annoying/complex way to do this with joins:
You'd need to combine multiple where conditions depending on the filter...but:
stream.uploads.joins(:files_blobs).where('active_storage_blobs.metadata LIKE ?', '%"analyzer":"MarcAnalyzer"%')
corylown
reviewed
Oct 27, 2025
| end | ||
|
|
||
| # Reset to page 1 if a filter is applied | ||
| page_number = params[:filter].present? ? 1 : params[:page] |
There was a problem hiding this comment.
Won't this mean that paging won't work if a filter is applied?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1262
You can view this at URLs like
/organizations/cornell/streams/48d9316f-85fc-4e38-8dcb-b22f1407301cBecause the
views/uploads/_file_table.html.erbis used by two different controllers / show pages -- uploads and streams -- this got a little weird. Both views want to render the table, but the internal paths for filtering are different -- and in the case of/uploads/:idwe don't even want the filtering.