feat: Make advisors observations configurable #4350
Closed
+140
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ThomasVitale
commented
Sep 9, 2025
ThomasVitale
commented
- Add possibility to provide a custom AdvisorObservationConvention to the ChatClient for customizing the conventions for advisor spans and metrics.
- Add ChatClientResponse to ChatClientObservationContext for achiving full visibility into both request and response.
* Add possibility to provide a custom AdvisorObservationConvention to the ChatClient for customizing the conventions for advisor spans and metrics. * Add ChatClientResponse to ChatClientObservationContext for achiving full visibility into both request and response. Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
ThomasVitale
force-pushed
the
gh-missing-observations-chat-client
branch
from
e53bac4 to
0f61161
Compare
|
@jonatan-ivanov could you review this? |
spring-ai-client-chat/src/main/java/org/springframework/ai/chat/client/ChatClient.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/springframework/ai/chat/client/observation/ChatClientObservationContext.java
Show resolved
Hide resolved
Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
|
It seems neither @sobychacko nor I can push to this PR (is edit by maintainers off?) so I rebased it on |
jonatan-ivanov
added
duplicate
|
Superseded by #4769 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.