feat: Make advisors observations configurable #4769
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add possibility to provide a custom AdvisorObservationConvention to the ChatClient for customizing the conventions for advisor spans and metrics. * Add ChatClientResponse to ChatClientObservationContext for achieving full visibility into both request and response. Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
jonatan-ivanov
commented
Oct 30, 2025
| public DefaultChatClientRequestSpec(ChatModel chatModel, @Nullable String userText, | ||
| Map<String, Object> userParams, Map<String, Object> userMetadata, @Nullable String systemText, | ||
| Map<String, Object> systemParams, Map<String, Object> systemMetadata, List<ToolCallback> toolCallbacks, | ||
| List<ToolCallbackProvider> toolCallbackProviders, List<Message> messages, List<String> toolNames, |
There was a problem hiding this comment.
Slightly related to this PR: during rebasing Thomas' changes, I found an extra param here: List<ToolCallbackProvider> toolCallbackProviders that wasn't there before, I guess that's a breaking change between 1.0 and 1.1. If that's ok, maybe the deprecated ctor can be removed too in this PR? (I prefer not breaking things though, that's why I kept it.)
|
Merged upstream via 3cf3db1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase + reactive support of @ThomasVitale's original changes in #4350: