[concurrency] Use nonisolated(unsafe) to quiet an error in runAsync in the tests. #2348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the tests. Specifically, we are already using XCTest expectations to make sure we are waiting long enough. So it is appropriate to put nonisolated(unsafe) since we are synchronizing the code in a way that swift concurrency does not understand. This came up as part of fixing rdar://164042741.
gottesmm
requested review from
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
Contributor
Author
|
Swift PR: swiftlang/swift#85164 |
Contributor
Author
Contributor
Author
Contributor
Author
|
@swift-ci test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, we are already using XCTest expectations to make sure we are waiting long enough. So it is appropriate to put nonisolated(unsafe) since we are synchronizing the code in a way that swift concurrency does not understand.
This came up as part of fixing rdar://164042741.