[rbi] When translating a Store, make sure to require src even if the value being stored is Sendable

[gottesmm]

This is important to ensure that we require the base of src if the src is non-Sendable (e.x.: a non-Sendable box).

rdar://163322459
#85107

[gottesmm]

@swift-ci smoke test

[slavapestov]

Can you add tests for the other cases mentioned in the report, for completeness? <T: AnyObject & Sendable>, and an AnyObject existential

[jamieQ]

any chance the solution here can be extended to address this case as well:

// https://github.com/swiftlang/swift/issues/82827
@MainActor
func test_82827() {
    var s = 1
    Task {
        for _ in 0..<100 {
            s += 1
        }
    }
    Task.detached { _ = s } // not diagnosed
}

or is that a separate problem?

[gottesmm]

That is a separate problem. I took a quick look and we are at least not assuming that placing the non-Sendable box into the first Task makes it MainActor isolated. I would need to look further to find the fix. But it isn't this.

[gottesmm]

@swift-ci smoke test

[gottesmm]

We are emitting an error on this now:

private func runAsync<T: Sendable>(_ body: @escaping @Sendable () async throws -> T) throws -> T {
  var result: Result<T, Error>!
  Task {
    do {
      result = .success(try await body())
    } catch {
      result = .failure(error)
    }
  }
  return try result.get()
}

[gottesmm]

swiftlang/sourcekit-lsp#2348

@swift-ci smoke test

[gottesmm]

swiftlang/sourcekit-lsp#2348

@swift-ci smoke test

[gottesmm]

swiftlang/sourcekit-lsp#2348

@swift-ci smoke test macOS platform